Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup scalafmt #258

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Setup scalafmt #258

merged 1 commit into from
Nov 14, 2020

Conversation

joroKr21
Copy link
Member

No description provided.

@joroKr21 joroKr21 force-pushed the scalafmt branch 2 times, most recently from 1c62e7f to 91d075f Compare October 24, 2020 17:57
@joroKr21 joroKr21 self-assigned this Oct 24, 2020
@joroKr21 joroKr21 added the Build label Oct 24, 2020
@joroKr21 joroKr21 requested a review from kailuowang October 24, 2020 18:11
@joroKr21 joroKr21 force-pushed the scalafmt branch 3 times, most recently from 7f1d066 to 02b4259 Compare October 25, 2020 10:51
@jatcwang
Copy link
Contributor

Hi @joroKr21, I'm planning to switch this over to github actions. Do you think we can get this in before I start to avoid the merge conflicts? (and I see you've already done some of the necessary upgrades such as sbt 1.4). Thanks :)

@joroKr21
Copy link
Member Author

Something's wrong with the validate command though - it's not working

@joroKr21 joroKr21 merged commit 99dffd5 into typelevel:master Nov 14, 2020
@joroKr21
Copy link
Member Author

@jatcwang done ✅ Thanks for picking this up! There is also #248 but we can ignore it because I would rather start from scratch on top of GitHub actions.

@joroKr21 joroKr21 deleted the scalafmt branch November 14, 2020 22:14
@jatcwang
Copy link
Contributor

Thanks @joroKr21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants