Add BaggageManager utility
#908
Merged
+506
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
added
enhancement
mergify
bot
added
module:oteljava
NthPortal
force-pushed
the
baggage-access/PR
branch
from
f1946fa to
c5dba2e
Compare
iRevive
reviewed
Feb 4, 2025
oteljava/common/src/main/scala/org/typelevel/otel4s/oteljava/baggage/BaggageManagerImpl.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Feb 4, 2025
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkContextKeys.scala
Show resolved
Hide resolved
|
Awesome improvements, thanks! |
iRevive
approved these changes
Feb 4, 2025
NthPortal
commented
Feb 4, 2025
| .unsafeRunSync() | ||
|
|
||
| private def baggageFromContext(context: Context): Baggage = | ||
| context.get(BaggageKey).getOrElse(Baggage.empty) |
There was a problem hiding this comment.
this can use context.getOrElse
There was a problem hiding this comment.
actually, that method doesn't exist, interesting
Add `BaggageManager` utility for accessing and modifying `Baggage` in `Local` context.
NthPortal
force-pushed
the
baggage-access/PR
branch
from
3a13fb2 to
969a121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
BaggageManagerutility for accessing and modifyingBaggageinLocalcontext.Closes #896.
I know that there are law tests for
Local, but I couldn't figure them out in a reasonable amount of time and I have a $work project to focus on as well. Happy for someone else to add them if desired.I believe all these changes are backwards binary compatible with the exception of
Otel4s(which gets a new abstract method to implement), but you shouldn't be implementing your ownOtel4sanyway