-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(develop): added phonenumber type validator to IsPhoneNumber.ts #2557
base: develop
Are you sure you want to change the base?
Conversation
Please check this change and let me know if anything needs to be modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpful changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changing
Hi @Sylar-3, what is the benefit of defining types inside the library instead of using original types from |
Thanks @shevchenkonik for your insight, actually there is no value in this as you just said, but this will make it easier for developers to check these types in the validator itself rather than going to the library and search for them. if there is any other question or issue please let me know since this pull request might help a lot in validating some APIs I'm using. |
Description
Added new feature to check the phonenumber type using .getType() method from libphonenumber-js
Checklist
Update index.md
)develop
)