Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream type support for express driver #182

Closed
wants to merge 3 commits into from
Closed

Stream type support for express driver #182

wants to merge 3 commits into from

Conversation

Luke265
Copy link

@Luke265 Luke265 commented Jun 13, 2017

No description provided.

@Luke265 Luke265 changed the title master Stream type support for express driver Jun 13, 2017
@pleerock
Copy link
Contributor

you made lot of dangerous changes. This part of code is complicated and without reason. I wont be able to accept this PR until all changes would be clear. If possible please make as small amount of changes as possible before we proceed. Thank you for this PR

@Luke265
Copy link
Author

Luke265 commented Jun 15, 2017

I've reduced code changes. Not sure why codecov returns errors.

@pleerock
Copy link
Contributor

Looks much better now. You'll also need to create a test case to cover this issue.

@pleerock pleerock mentioned this pull request Jun 27, 2017
Closed
@pleerock
Copy link
Contributor

@Luke265 did you have chance to finish this PR?

MichalLytek
MichalLytek suggested changes Aug 6, 2017
View reviewed changes
Copy link
Contributor

@MichalLytek MichalLytek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok but we need small unit test case which will check whether the pipe feature works - @Luke265 can you do this? 😉

@MichalLytek MichalLytek mentioned this pull request Sep 8, 2017
Merged
@MichalLytek
Copy link
Contributor

Closing in favour of #285.

@MichalLytek MichalLytek closed this Sep 8, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalLytek MichalLytek MichalLytek requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luke265 @pleerock @MichalLytek