Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/auhorized decorator koa #242

Merged
merged 3 commits into from
Aug 7, 2017
Merged

Fix/auhorized decorator koa #242

merged 3 commits into from
Aug 7, 2017

Conversation

NoNameProvided
Copy link
Member

No description provided.

@NoNameProvided NoNameProvided mentioned this pull request Aug 7, 2017
Closed
@NoNameProvided NoNameProvided merged commit faf0f15 into typestack:master Aug 7, 2017
@MichalLytek
Copy link
Contributor

MichalLytek commented Aug 7, 2017 •
edited
Loading

@NoNameProvided
Looks like you've merged this PR with rebase. It's a bad idea, you should always make a merge commit in order to have nice history and keep track of PR and changes on branches.

@NoNameProvided
Copy link
Member Author

NoNameProvided commented Aug 8, 2017 •
edited
Loading

At work we prefer clean history, but it's totally fine for me to do merge commits. I wont rebase in the future 👍

@MichalLytek
Copy link
Contributor

That's why rebase on github looks bad 😜

image

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalLytek MichalLytek MichalLytek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoNameProvided @MichalLytek