Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): reject multiple calls #484

Closed
wants to merge 2 commits into from
Closed

Conversation

unix
Copy link

@unix unix commented Apr 11, 2019

Reject action duplicate calls caused by unsatisfactory design.
About issue: #220 .

fixed #220 .

@github-actions
Copy link

github-actions bot commented Feb 6, 2020

Stale pull request message

@ArthurMelin
Copy link
Contributor

This could also be fixed by appending an empty handler to the list of middlewares when registering the action in the driver so that express stops handling the request.
Also, is this project still maintained? This PR is 10 months old without any response from anyone but bots...
@pleerock hello?

@jotamorais
Copy link
Member

This could also be fixed by appending an empty handler to the list of middlewares when registering the action in the driver so that express stops handling the request.
Also, is this project still maintained? This PR is 10 months old without any response from anyone but bots...
@pleerock hello?

@Elassyo, I took over and I'm trying to first categorize and prioritize what can/need to be fixed first (that's why you see some bot activity lately).
Ideas, comments, suggestions on how to do that are more than welcome - so are PRs :)

@github-actions github-actions bot closed this Feb 19, 2020
@unix
Copy link
Author

unix commented Feb 19, 2020

@jotamorais
@Elassyo
@pleerock

Use bot to shut down prs & issues rather than deal with them, it's just a cover up, not a solution.
As a user & contributor, I feel very disappointed.

I want every user to see these processes, and watch out for managers' inaction, and please use this opensource project very very carefully

@jotamorais
Copy link
Member

@jotamorais
@Elassyo
@pleerock

Use bot to shut down prs & issues rather than deal with them, it's just a cover up, not a solution.
As a user & contributor, I feel very disappointed.

I want every user to see these processes, and watch out for managers' inaction, and please use this opensource project very very carefully

@unix, the idea to add the bot and to flag stale and close stale issues and PRs was to trigger action (and as you can see, triggered your action too). We had over 150 open issues and 18 old PRs (some open since 2017).
I got permission to manage the Github and NPM's repositories late last October and I've already released 3 versions with important changes.
Other changes with more potential to break the backward compatibility need to be more carefully evaluated and tested, understand if it makes sense to change, etc.

No one is trying to cover up or not deal with the issues (we didn't delete the issue - it's closed with a stale flag) and we will get back to it at some point.
The idea is to use the bots to clear up the queue, bring the community together (not by trying to raise awareness with false allegations and "screaming").

I certainly appreciate your PR and any contribution, but there's no need to shout this kind of statements out in the wind. On the contrary, we should be calling for more ideas and contributions on how to put the project back on track.

What are your suggestions?

@jotamorais jotamorais reopened this Feb 19, 2020
jotamorais added a commit that referenced this pull request Feb 19, 2020
As suggested in #537 and #484, I'm disabling the state bot in favor of better ideas
@unix unix closed this Mar 4, 2020
@unix unix deleted the multiple-calls branch March 4, 2020 09:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

One url make 2 action call
4 participants