WPI: decision on whether to infer a type for a type variable should be made based on explicit annotations #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillst
previously approved these changes
Feb 8, 2023
… script code that appears to have been copied into the nullness jaifs test from the ainfer-testchecker test
…mework into typevar-return-loop
|
This includes the changes in #5620 now, so we probably should wait to merge this until after that PR is merged. |
|
@smillst I think this PR got overlooked. I'm the original author, so I can't approve it, but the changes you made look good to me. I've set it to auto-merge, so if you approve it and the tests pass, we should be good. |
smillst
approved these changes
Mar 1, 2023
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Mar 7, 2023
…e made based on explicit annotations (typetools#5618) --------- Co-authored-by: Suzanne Millstein <[email protected]> Co-authored-by: Michael Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the effective annotations are used, types from previous rounds of inference are considered, leading to flip-flopping behavior in subsequent inference rounds (e.g., in round 1 the type is inferred; in round 2 it is not inferred because it is already present; in round 3 it is no longer present and therefore inferred; etc.).