Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Ainfer Nullness Jaifs test #5620

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Cleanup Ainfer Nullness Jaifs test #5620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c391025
skip new test validation for jaifs, and also remove some unused build…
kelloggm Feb 8, 2023
011605b
remove code that was specific to that other PR
kelloggm Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions checker/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,7 @@ task ainferResourceLeakAjavaTest(dependsOn: 'shadowJar', group: 'Verification')
dependsOn(ainferResourceLeakValidateAjava)
outputs.upToDateWhen { false }
}

task ainferNullnessGenerateJaifs(type: Test) {
description 'Internal task. Users should run ainferNullnessJaifTest instead. This type-checks the ainfer-nullness files with -Ainfer=jaifs to generate .jaif files'

Expand All @@ -814,11 +815,6 @@ task ainferNullnessGenerateJaifs(type: Test) {
doLast {
copyNonannotatedToAnnotatedDirectory('ainfer-nullness')

// JAIF-based WPI fails these tests, which was added for stub-based WPI.
// See issue here: https://github.com/typetools/checker-framework/issues/3009
delete('tests/ainfer-nullness/annotated/ConflictingAnnotationsTest.java')
delete('tests/ainfer-nullness/annotated/MultiDimensionalArrays.java')

// JAIF-based WPI does not infer annotations on uses of type variables correctly.
delete('tests/ainfer-nullness/annotated/TwoCtorGenericAbstract.java')

Expand Down