Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the @OptionalBottom type and annotation #6772

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Removing the @OptionalBottom type and annotation #6772

merged 11 commits into from
Sep 4, 2024

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented Aug 31, 2024

No description provided.

@jyoo980 jyoo980 requested review from mernst and smillst August 31, 2024 21:00
@jyoo980 jyoo980 changed the title Removing the @OptionalBottom annotation Removing the @OptionalBottom type and annotation Aug 31, 2024
@jyoo980 jyoo980 self-assigned this Aug 31, 2024
mernst
mernst requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
There is one thing that needs to be fixed (see figure 5.1 in the PDF manual).

@jyoo980 jyoo980 requested a review from mernst September 2, 2024 13:11
@jyoo980 jyoo980 assigned mernst and unassigned jyoo980 Sep 2, 2024
mernst
mernst approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mernst mernst assigned smillst and unassigned mernst Sep 3, 2024
@mernst
Copy link
Member

mernst commented Sep 3, 2024

@smillst Please merge when it won't interfere with the release. (Feel free to review, as well.)

@smillst smillst enabled auto-merge (squash) September 3, 2024 21:01
@smillst smillst merged commit 0aeb0a4 into typetools:master Sep 4, 2024
36 checks passed
@mernst mernst deleted the yoo/remove-optional-bottom branch September 6, 2024 20:02
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Feb 7, 2025
@jyoo980 @mernst @wmdietl
Removing the @OptionalBottom type and annotation (typetools#6772)
936fdc0 
Co-authored-by: Michael Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mernst mernst mernst approved these changes

@smillst smillst smillst approved these changes

Assignees

@smillst smillst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyoo980 @mernst @smillst