Feat: Support for bulk insertion #931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2019 13:17
Threat the request param as integer closes typicode#925, closes typicode#396
Added support for bulk insertion on plural routes and nested routes, closes typicode#482
|
@typicode could we get this feature merged? |
|
Any updates on when this may get merged? |
We actually needed the fix really badly, so we created our own fix. (somehow the test that is commented out there was failing on my machine, you can ignore that change) |
When nested route is called with a non numeric id it should not be parsed to int, otherwise numbers or numeric strings are parsed to int with base 10
|
LGTM now! |
jjsub
approved these changes
Mar 20, 2020
alesmit
approved these changes
May 8, 2020
|
Any reason why this hasn't been merged yet? |
|
Will this be merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for bulk insertion when posting array to plural and nested routes.
When a single object is posted it work as usual, when an array (of objects) is posted it will perform bulk insertion.
Also the id field is parsed into number to fix match issues, see #396