Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12 group-heading-level #67

Closed
quachpas opened this issue Oct 21, 2024 · 1 comment · Fixed by #73
Closed

v0.12 group-heading-level #67

quachpas opened this issue Oct 21, 2024 · 1 comment · Fixed by #73
Assignees
Milestone

Comments

@quachpas
Copy link
Collaborator

          Hi, two questions about the `group-heading-level` fix:

1- Sorry for bothering, but what's the current status on this?

2- Wouldn't it be better if the default value for group heading levels, instead of being "the same as the previous", was "the same as the previous, plus one"? I understand that this PR aims to allow the user to choose, but the thing is that the default value before Typst 0.12 was "plus one", and honestly it seems more logical to me (I'm open to counter-arguments though). Besides, I've only just noticed, completely by chance, that the current value breaks my post-0.12 template, and I suspect that this breakage is the same with the majority of the users at this point.

Originally posted by @tfachada in #60 (comment)

@tfachada
Copy link
Contributor

For the sake of the argument, might as well post my followup to a reply that comment got:

My point with +1 being more logical is that a group is supposed to be a subcategory of terms within the glossary, and as such having a h1 "Glossary" title followed by also h1 titles for groups would be the same thing logically (in terms of outline) as multiple glossaries. Though then again, the workaround I found, which I suppose may be the same as yours, would be to print multiple glossaries too but with h2 titles before the subcategory ones, so the group feature might be pointless.

Personally, I am at this point indifferent to what is done here, since I went with said workaround (implemented here). I still think right now, though, that if the group feature is to be kept, then it should be in the +1 form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants