Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of collapsed numeric citations #176

Merged
merged 11 commits into from
Aug 8, 2024

Conversation

bluebear94
Copy link
Contributor

Fixes #154.

Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is looking great! I have a few comments.

src/csl/archive.rs Outdated Show resolved Hide resolved
src/csl/mod.rs Outdated Show resolved Hide resolved
src/csl/mod.rs Outdated Show resolved Hide resolved
src/csl/mod.rs Outdated Show resolved Hide resolved
@PgBiel PgBiel merged commit 954962e into typst:main Aug 8, 2024
1 check passed
@PgBiel
Copy link
Contributor

PgBiel commented Aug 8, 2024

Thank you! 💙

danilasar pushed a commit to danilasar/hayagriva that referenced this pull request Dec 31, 2024
* Update preset styles

* Add failing test for typst#154

* Fix formatting of collapsed numeric citations

* Revert changes to archive

* Refactor collapse_items

* Replace collapse test with local version

* Remove styles/numeric.csl

* simplify test

* slightly improve collapse code

* remove redundant test import

* wrap comment at 80 columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants