Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up minor bug in the Mssql Eventstore #21

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JamesTryand
Copy link

SqlServer was not working against the existing code as the insert wasn't working properly, due to mssql not accepting the datetime format given. So have explicitly converted the datetime string into a format that it likes and converted across.

There are a couple of other minor fixes to the sample project - in that the output folders were different for the sqlserver eventstore and this has now been aligned, and the signature for the config has been updated to match that in the SimpleCQRS store.

@darrencauthon
Copy link
Collaborator

Does src/EventStores/SimpleCqrs.EventStore.SqlServer/SqlServerEventStore.cs work for you?

@JamesTryand
Copy link
Author

It didn't to begin with, as the system threw an error as it couldn't insert the datetime string into the sql field.
so i just changed it so the insert eventdate field is converted to use the sortable datetime ( as that was the only one i could get to work in sqlserver ), i also changed the insert string to do a convert from string on the insert.

I checked this on two different windows 7 machines, one with a sqlserver 2005 database and one with a sqlserver 2008 database.

@darrencauthon
Copy link
Collaborator

Oh, sorry -- I saw you committed to the sample, but I didn't catch the commits to the actual event store immediately below.

@tyronegroves
Copy link
Owner

Thanks!!! I will check it out and merge it.

@JamesTryand
Copy link
Author

You're welcome, once you've got that, i need to refresh the samples and push them, but in my fork you'll find a mysql eventstore based on the mssql one ( cos I need one for my hosting provider :-) ).

@tyronegroves
Copy link
Owner

I sorry James but I have been really busy lately. I will get this pulled in by the EOW.

@JamesTryand
Copy link
Author

No Worries ;-)

I've done a mysql eventstore based on the mssql one if you're interested.

On Thu, May 24, 2012 at 10:36 PM, Tyrone Groves <
[email protected]

wrote:

I sorry James but I have been really busy lately. I will get this pulled
in by the EOW.

@darrencauthon
Copy link
Collaborator

He's interested.

@tyronegroves
Copy link
Owner

Yeah I am Darren :)

@JamesTryand
Copy link
Author

I'll push it to my thing in a bit and do another pull request in a bit.
(I'm reconing in about 3 hours time, just got some other stuff to sort out
first). oh yeah, i use Greg Young's Simple.Testing for test harness, I've
done a quick sample for it on gist, the generic one isn't working with
autotest.net/mightymoose at the moment, but the non generic one is simple
enough to T4-ize/snippet.

( scroll down to the bottom it's in the 'non generic example' region) of
TestsAndHarness.cs

https://gist.github.com/2779864

On Thu, May 24, 2012 at 10:51 PM, Tyrone Groves <
[email protected]

wrote:

Yeah I am Darren :)


Reply to this email directly or view it on GitHub:
#21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants