-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing up minor bug in the Mssql Eventstore #21
base: master
Are you sure you want to change the base?
Conversation
…sqlserver sample to work with the change.
Does src/EventStores/SimpleCqrs.EventStore.SqlServer/SqlServerEventStore.cs work for you? |
It didn't to begin with, as the system threw an error as it couldn't insert the datetime string into the sql field. I checked this on two different windows 7 machines, one with a sqlserver 2005 database and one with a sqlserver 2008 database. |
Oh, sorry -- I saw you committed to the sample, but I didn't catch the commits to the actual event store immediately below. |
Thanks!!! I will check it out and merge it. |
…ed queries rather than composed strings.
You're welcome, once you've got that, i need to refresh the samples and push them, but in my fork you'll find a mysql eventstore based on the mssql one ( cos I need one for my hosting provider :-) ). |
I sorry James but I have been really busy lately. I will get this pulled in by the EOW. |
No Worries ;-) I've done a mysql eventstore based on the mssql one if you're interested. On Thu, May 24, 2012 at 10:36 PM, Tyrone Groves <
|
He's interested. |
Yeah I am Darren :) |
I'll push it to my thing in a bit and do another pull request in a bit. ( scroll down to the bottom it's in the 'non generic example' region) of https://gist.github.com/2779864 On Thu, May 24, 2012 at 10:51 PM, Tyrone Groves <
|
… include in the application.
SqlServer was not working against the existing code as the insert wasn't working properly, due to mssql not accepting the datetime format given. So have explicitly converted the datetime string into a format that it likes and converted across.
There are a couple of other minor fixes to the sample project - in that the output folders were different for the sqlserver eventstore and this has now been aligned, and the signature for the config has been updated to match that in the SimpleCQRS store.