Fix tests at HEAD; update to newer bazel #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hugelgupf
commented
Mar 28, 2022
•
hugelgupf
commented
- build-gomod-multi-go117 should still fail until go:embed support #66 is merged,
- build-gomod-go116 will be fixed by this
- supplies a docker image with much newer bazel version
Signed-off-by: Chris Koch <[email protected]>
This is necessary because the new rules_go and gazelle versions require a version of bazel newer than what's in the GCR docker image pre-built by the bazel team. Apparently, they stopped building those in 2020. bazelbuild/continuous-integration#1060 Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
gokrazy does not have a valid go.sum file according to Go 1.16, so we gotta pin it to before it got messed up. Signed-off-by: Chris Koch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.