-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript refactor #2685
Merged
Merged
Typescript refactor #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the load trigger. This doesn't fully do it. The underlying problem is that the `media` array for a playlist may not be populated in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
üWave does some pretty complex stuff to maintain playlist state and reuse components with different data, and that sometimes goes wrong at runtime. I'm working on adding typechecking so we can solve some issues, eg. statically check that the media list implementation can actually be used with playlist items, search results, and history entries.
Some of the patterns in the client are not really friendly to typescript. Especially the HTTP request redux middleware I can't really get to work well, but that is one of the most beneficial things to get types from, because it lets us check that we're handling API responses correctly. I'm moving some of that stuff to SWR. I think there's an opportunity to simplify a lot that way as well as about half of our redux complexity is just about maintaining a client-side cache of server-side state, which SWR can do much more easily.
Not totally sure where this will end up, will just do bits and pieces whenever I want, but that's the current status
Todos before merge: