Do not hide playlist items when playlist meta is loading #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a playlist is in the loading state, that doesn't actually mean that its items should not be accessible. For example, a playlist is loading while you're activating it. It doesn't make sense to then show a loading spinner covering the whole playlist manager. We already show a loading icon on the playlist name. With this change, playlist deletion / activation / selection / adding items don't place a loading spinner on the whole playlist panel. Only when the playlist is in the loading state *and* doesn't have any items loaded yet, do we show the whole-screen spinner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when playing with #2972 but it actually happens in many situations.
When a playlist is in the loading state, that doesn't actually mean that its items should not be accessible. For example, a playlist is loading while you're activating it. It doesn't make sense to then show a loading spinner covering the whole playlist manager. We already show a loading icon on the playlist name and that's indication enough.
With this change, playlist deletion / activation / selection / adding items don't place a loading spinner on the whole playlist panel. Only when the playlist is in the loading state and doesn't have any items loaded yet, do we show the whole-screen spinner.