Add support for macOS Monterey 12 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honor the cached/command-line provided CMAKE_OSX_ARCHITECTURES. Disabled the post_cmake Xcode "fixes" that seem to have broken with the usage of Apple's Arm processors. Diable xcpretty by default in the rakefile for more thorough error messages (can be enabled with the USE_XCPRETTY environment variable).
…ng generated/toluabind.c, which was used to build tolua++). For example, this error: > error: Build input file cannot be found: '/Users/runner/work/U3D/U3D/build/ci/Source/ThirdParty/toluapp/src/bin/generated/toluabind.c'. > Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'tolua++' from project 'Urho3D')
|
Also addresses #28, though not completely (we should probably not require two builds of the library to use the newly generated toluabind.{c,h} code). It is possible that just enabling the new build system would fix the build failure without this change, but I have not tested that. |
|
And I can confirm that all of the samples I have tried run successfully. (Which granted was only a few of them). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12.
I have not tested actually running any applications, but the builds at least complete now on both the github runner and my local machine. Though locally I did encounter some errors related to signing the code (I have not set that up yet) when I did not set the environment variable
CI=true.Most of the fixes, it turns out, where actually just disabling a lot of the previous fixes and build optimizations that had been applied in the build system - it seems they are no longer useful with the newer CMake and Xcode (and end up causing problems instead of solving them). Possibly this breaks builds on systems with older CMake/Xcode.