Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noviello.it: detection #11204

Closed
7 of 8 tasks
Yuukiiro opened this issue Jan 5, 2022 · 46 comments
Closed
7 of 8 tasks

noviello.it: detection #11204

Yuukiiro opened this issue Jan 5, 2022 · 46 comments

Comments

@Yuukiiro
Copy link

Yuukiiro commented Jan 5, 2022

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO (also mind browser built-in blockers)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://noviello.it/es/como-hacer-operaciones-matematicas-con-javascript/

Category

detection

Describe the issue

Shows popup when detects the adblck.

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.40.4
Chromium: 96
filterset (summary): 
  network: 80757
  cosmetic: 44614
  scriptlet: 16584
  html: 0
listset (total-discarded, last updated): 
  default: 
    easylist: 62457-8, 3d.55m
    easyprivacy: 26597-18, 10h.8m
    plowe-0: 3715-818, 11d.6h.9m
    spa-0: 3570-21, 1d.56m
    spa-1: 4173-159, 10h.15m
    ublock-abuse: 76-0, 10h.9m
    ublock-badware: 3539-64, 10h.12m
    ublock-filters: 30046-197, 10h.13m
    ublock-privacy: 182-12, 10h.11m
    ublock-unbreak: 1678-41, 10h.7m
    urlhaus-1: 7408-0, 1d.57m
filterset (user): [empty]
trustedset: 
  added: [array of 5 redacted]
switchRuleset: 
  added: [array of 1 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  launchToReadiness: 3161 ms (selfie)
popupPanel: 
  blocked: 20
@mapx-
Copy link
Contributor

mapx- commented Jan 5, 2022

Are you using brave browser ? if the shields are ON for this site you'll get anti adb stuff
@Yuki2718

@uBlock-user
Copy link
Contributor

To reproduce just enable ITA: ABP X Files. bait is .adsbox

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

ITA: ABP X Files is not enabled by default for users with an italian locale.

@uBlock-user
Copy link
Contributor

So only EasyList Italy ? @gorhill

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

So only EasyList Italy

Yes.

image

uBlock-user added a commit that referenced this issue Jan 6, 2022
@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 6, 2022

I don't see anti-adb even with .adsbox blocked and instead see bab only if Brave Shield enabled as suggested by @mapx- . This may be con-argument for removing specific bab filters as noviello.it##+js(nosiif, visibility, 1000) blocks that even with Shield enabled, tho keeping it enabled is ofc bad idea.

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 6, 2022

But in any case generic ##.adsbox is bad filter, already removed from all AG lists: AdguardTeam/AdguardFilters@d1c0942 So I'll add #@#.adsbox. 209995c

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

Why? The filter is in a non default list.
I am sure there are many lists out there with "bad filters".
We can't "fix" all of those in our lists.

@uBlock-user
Copy link
Contributor

@Yuki2718 --
Capture

That's how it looks like.

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

I am in favour of removing ITA: ABP X Files from the regional list.
As far as I can see it's the only one in there that's not enabled by default.
@gorhill

@uBlock-user
Copy link
Contributor

We shouldn't bother with non-default lists. That's not under our purview. I'm rather curious as to why it's not enabled by default like we have for SPA and POL locales.

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 6, 2022

@uBlock-user Oh, I missed that.

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 6, 2022

Why? The filter is in a non default list. I am sure there are many lists out there with "bad filters". We can't "fix" all of those in our lists.

You're right. I'll revert the commit.

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

like we have for SPA and POL locales.

For the spanish lists, one of them is spanish and portuguese.
For the polish lists, one of them deals with anti adblock issues specifically, the other one refuses to fix those.

@uBlock-user
Copy link
Contributor

Has @gorhill stated that anywhere before ?

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

stated that anywhere before ?

What exactly?
If you mean the polish lists, I remember the discussion when the main polish list started to refuse fixing anti adblock issues and the second list was created because of that.

@uBlock-user
Copy link
Contributor

What exactly?

The specific reasons you mentioned in #11204 (comment)

@okiehsch
Copy link
Contributor

okiehsch commented Jan 6, 2022

I think he was involved in the decision to enable two polish lists as I said above.
If I remember correctly the two spanish lists were always enabled by default, so the reason I gave is just a guess on my part.

@uBlock-user
Copy link
Contributor

I don't see how ITA: ABP X Files complements EL list like the SPA and POL lists do. So removal is not a bad idea.

@gorhill
Copy link
Member

gorhill commented Jan 6, 2022

I'm going to remove ABP X Files, I see filters that are unrelated to ITA sites in there -- I probably added this list in the very early days when I was less strict about which lists were added.

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 6, 2022
@gioxx
Copy link

gioxx commented Jan 8, 2022

So, a list that has been around since the dawn of time and is very much used in Italy, is removed because there is a filter that does not work properly, all without even pinging me that in a few seconds I could have eliminated that filter remedying the problem.

The fact of being present in the options, facilitates the use by Italian users who have an alternative directly from uBlock instead of adding the URL by hand, which is convenient for those less accustomed to technology.

It seems to me that the reasoning does not make a fold.

@gorhill
Copy link
Member

gorhill commented Jan 8, 2022

"ABP X Files" was the only regional list left not being enabled by default -- I removed many such lists in the past to ensure that the section is used only for lists which are enabled by default in at least a country/language.

@gioxx
Copy link

gioxx commented Jan 10, 2022

Don't worry @gorhill, I can understand your argument but don't agree with it for the very reasons stated above. I still strongly support the choice of uBlock for any X Files user and will do so again in the future, I will simply point out via documentation / official X Files website that it will now need to be added manually or go through filterlists.com.

@Nomes77
Copy link
Contributor

Nomes77 commented Jan 13, 2022

stated that anywhere before ?

What exactly? If you mean the polish lists, I remember the discussion when the main polish list started to refuse fixing anti adblock issues and the second list was created because of that.

As EasyList Dutch is also refusing to fix anti-adblock (see: easylist/easylistdutch#11 (comment); easylist/easylistdutch#30 (comment))
and EasyDutch does fix it and is specific for uBlock
maybe you(@gorhill) could add it as Dutch default?

@JohnyP36
Copy link

JohnyP36 commented Jan 13, 2022

Ok I see, you are the maintainer of EasyDutch. So if I understand correctly, you mirror EasyList Dutch, but further include filters for uBO's syntax. From what I see in the repo, this seems like a good move to replace EasyList Dutch with EasyDutch. @mapx, @okiehsch, @uBlock-user etc any thoughts?

When I enable both EasyList Dutch and EasyDutch, I see ~700 filters rejected as duplicate in EasyDutch, while there are 1230 filters in EasyList Dutch. Why the discrepancy?

An important reason for this is that EasyList Dutch contain a bunch outdated rules.
Also EasyList Dutch and EasyDutch blocks elements on a different way.
Example:
JohnyP36/Personal-List@9b62d78 : meerdangewenst.nl##[class*="footer-section"]:has(.sponsoren)
versus EasyList Dutch easylist/easylistdutch@7626f32#diff-0582a3da4495ad4b284040b5cd6a21085b67befc5d5fa6dedf71acf692e12d7cR407 : meerdangewenst.nl##.tg-site-footer-section-1
I guess this makes the difference of ~500.

Btw, I also have a mirror of EasyList Dutch

@uBlock-user
Copy link
Contributor

@uBlock-user etc any thoughts?

Sure, if you feel like giving him a second chance after gorhill/uBlock@9e394aa

@JohnyP36
Copy link

@uBlock-user etc any thoughts?

Sure, if you feel like giving him a second chance after gorhill/uBlock@9e394aa

You could use my list. Wich is almost the same
My repo is: https://github.com/JohnyP36/Personal-List

@uBlock-user
Copy link
Contributor

@JohnyP36 You also run a public list for NLD locale ?

@JohnyP36
Copy link

JohnyP36 commented Jan 13, 2022

@JohnyP36 You also run a public list for NLD locale ?

Yes


subscribe url: Dutch Filter List

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 13, 2022

@JohnyP36 BTW your list has some redundancy:

itdaily.be###itdaily-article-sidebar has been made redundant by itdaily.be###itdaily-article-sidebar
kinderspelletjes.be###adRechts has been made redundant by ###adRechts
deoudrotterdammer.nl##.advertentie has been made redundant by ##.advertentie
dorpsklanken.online##.advertenties has been made redundant by ##.advertenties
camsexbabe.nl##.d-md-block.d-none.video-sidebar has been made redundant by camsexbabe.nl,mijnpornotube.nl,pornosterneuken.nl,sexbios.net,sexdatingtube.be##.video-sidebar
||transport-online.nl/site/includes/uploads/banner-*$image has been made redundant by ||transport-online.nl/site/includes/uploads/banner-
||system.adquick.nl^$third-party has been made redundant by ||adquick.nl^$third-party
||pornokartel.nl/wp-admin*&campaigns=*&banners*$script,third-party has been made redundant by ||pornokartel.nl^$third-party
||static-cdn.spott.ai^$third-party has been made redundant by ||spott.ai^
||i3.wp.com/www.appletips.nl/wp-content/uploads/cnmx.*$image,domain=appletips.nl has been made redundant by ||wp.com/www.appletips.nl/wp-content/uploads/cnmx$image,domain=appletips.nl

@Nomes77
Copy link
Contributor

Nomes77 commented Jan 13, 2022

EasyList Dutch is also refusing to fix anti-adblock

Maintainer could add !#include ... directives to load the filters for uBO, ABP will ignore this.

Ok I see, you are the maintainer of EasyDutch. So if I understand correctly, you mirror EasyList Dutch, but further include filters for uBO's syntax. From what I see in the repo, this seems like a good move to replace EasyList Dutch with EasyDutch. @mapx, @okiehsch, @uBlock-user etc any thoughts?

When I enable both EasyList Dutch and EasyDutch, I see ~700 filters rejected as duplicate in EasyDutch, while there are 1230 filters in EasyList Dutch. Why the discrepancy?

To add to @JohnyP36 reaction: there are a lot of general filterrules in EasyList Dutch which I deleted, because i could never reproduce anymore.

@uBlock-user etc any thoughts?

Sure, if you feel like giving him a second chance after gorhill/uBlock@9e394aa

Yes, I would be nice if you give me a second change.
I promise you I'm not going break your trust anymore

@JohnyP36
Copy link

@Yuki2718 Thanks
I will remove them.
You could make an issue or PR in my repo as an reminder (for me to remove).

@JohnyP36
Copy link

JohnyP36 commented Jan 13, 2022

@JohnyP36 You also run a public list for NLD locale ?

Yes, he does. But my list EasyDutch is spesific for uBlock Origin with standard lists enabled. While @JohnyP36 list is not and support also Adguard.

Partly true, Adguard recognizes uBlock syntax.
But my rules are according the uBlock syntax rules.

@BPower0036 make issues if there's something wrong in my list

JohnyP36 added a commit to JohnyP36/Personal-List that referenced this issue Jan 13, 2022
@Nomes77
Copy link
Contributor

Nomes77 commented Jan 13, 2022

@JohnyP36 You also run a public list for NLD locale ?

Yes, he does. But my list EasyDutch is spesific for uBlock Origin with standard lists enabled. While @JohnyP36 list is not and support also Adguard.

Partly true, Adguard recognizes uBlock syntax. But my rules are according the uBlock syntax rules.

To give some examples:
$3p vs $third-party
$xhr vs $xmlhttprequest
$1p vs $first-party
And thing like this:
#?#.text-center:-abp-contains(advert) in stead of ##.text-center:has(advert)
#$#[src="http://audiobookbay.nl/images/dir.gif"]{ width: 100px !important } (this is clearly Adguard syntax)
instead of ##[src="http://audiobookbay.nl/images/dir.gif"]:style(width: 100px !important )

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jan 13, 2022

To give some examples: $3p vs $third-party $xhr vs $xmlhttprequest $1p vs $first-party And thing like this: #?#.text-center:-abp-contains(advert) in stead of ##.text-center:has(advert)

These are no problem. #$#[src="http://audiobookbay.nl/images/dir.gif"]{ width: 100px !important } (this is clearly Adguard syntax) too, works fine on uBO.

@Nomes77
Copy link
Contributor

Nomes77 commented Jan 13, 2022

To give some examples: $3p vs $third-party $xhr vs $xmlhttprequest $1p vs $first-party And thing like this: #?#.text-center:-abp-contains(advert) in stead of ##.text-center:has(advert)

These are no problem.

I know but I use only uBlock syntax and no others, while @JohnyP36 does it.

I mentioned all those things so you know the difference between our lists

@mapx-
Copy link
Contributor

mapx- commented Jan 13, 2022

It would be an advantage for all of us to replace EasyList Dutch by @BPower0036 list.
You could (@BPower0036 @JohnyP36 ) collaborate to keep / maintain just one single list.

@Nomes77
Copy link
Contributor

Nomes77 commented Jan 13, 2022

@mapx- To say the truth, I made my list first. But somehow @JohnyP36 also wanted a list for himself.
But we can collaborate, that is very easy since we are brothers and live in one house

@JohnyP36
Copy link

It would be an advantage for all of us to replace EasyList Dutch by @BPower0036 list. You could (@BPower0036 @JohnyP36 ) collaborate to keep / maintain just one single list.

Although I will keep my repo, (in case of...) I would like to collaborate on EasyDutch.

That would be more efficient and easier for you.

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 15, 2022
@Nomes77
Copy link
Contributor

Nomes77 commented Apr 14, 2022

@gorhill Since i can't comment on your commit.

Can you use as contentURL https://raw.githubusercontent.com/EasyDutch-uBO/EasyDutch/gh-pages/EasyDutch.txt
as I (we) now use gh-pages?

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 14, 2022
@gorhill
Copy link
Member

gorhill commented Apr 14, 2022

gorhill/uBlock@09666fd

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 20, 2022
@gorhill
Copy link
Member

gorhill commented Apr 20, 2022

Done: gorhill/uBlock@3af9cd2

I did not include gitlab url, it should not be used as CDN.

@Nomes77
Copy link
Contributor

Nomes77 commented Jan 16, 2023

@gorhill I don't know if https://github.com/uBlockOrigin/uBlock-issues/issues/ is the correct place to ask.

But here are the new CDN's, because I made https://easydutch-ubo.github.io/EasyDutchCDN/ and removed my GitLab account:

https://easydutch-ubo.github.io/EasyDutchCDN/EasyDutch.txt
https://cdn.statically.io/gh/EasyDutch-uBO/EasyDutch/gh-pages/EasyDutch.txt
https://cdn.jsdelivr.net/gh/EasyDutch-uBO/EasyDutch@gh-pages/EasyDutch.txt
https://cdn.statically.io/gh/EasyDutch-uBO/EasyDutchCDN/main/EasyDutch.txt
https://cdn.jsdelivr.net/gh/EasyDutch-uBO/EasyDutchCDN@main/EasyDutch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants