-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger reports generic cosmetic filter instead of a specific #2092
Comments
Did some digging. 1.39.2 is the last stable version where this works correctly. |
@peace2000 is this fixed in 1.42.4? I cannot reproduce in Nightly. |
No, I can repro this issue in that version as well. 1.39.2 is the last stable version where this works correctly. |
Weird. It really must be related with sequence of data in storage, because no matter what I do, I cannot reproduce in dirty profile. I can in clean installation. |
Hypothesis: Could be a regression from gorhill/uBlock@72bb894. |
Related issue: - uBlockOrigin/uBlock-issues#2092 Regression from: - 72bb894
Tested the latest dev build, seems to be working. |
Prerequisites
I tried to reproduce the issue when...
Description
If there's the same cosmetic filter as a generic and as a specific, the logger reports the generic being loaded instead of the specific, if the generic filter is listed before the specific filter in the filter list.
A specific URL where the issue occurs
elisaviihde.fi
Steps to Reproduce
##.ea-cookie-disclaimer
elisaviihde.fi##.ea-cookie-disclaimer
elisaviihde.fi
In the logger, you'll see that the generic filter is reported instead of the specific.
If you change the order:
elisaviihde.fi##.ea-cookie-disclaimer
##.ea-cookie-disclaimer
Logger will report the specific one as it should.
Expected behavior
The logger would always report the specific filter over the generic as it was the purpose of this commit:
gorhill/uBlock@c25938f
Actual behavior
The logger reports a generic cosmetic filter over a specific one, if the generic filter is listed before the specific in the list.
uBlock Origin version
1.42.5b1
Browser name and version
Firefox 99.0.1
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: