Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger reports generic cosmetic filter instead of a specific #2092

Closed
8 tasks done
peace2000 opened this issue Apr 17, 2022 · 6 comments
Closed
8 tasks done

Logger reports generic cosmetic filter instead of a specific #2092

peace2000 opened this issue Apr 17, 2022 · 6 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@peace2000
Copy link
Member

peace2000 commented Apr 17, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

If there's the same cosmetic filter as a generic and as a specific, the logger reports the generic being loaded instead of the specific, if the generic filter is listed before the specific filter in the filter list.

A specific URL where the issue occurs

elisaviihde.fi

Steps to Reproduce

  1. Add these to your own filters manually, in this order:
    ##.ea-cookie-disclaimer
    elisaviihde.fi##.ea-cookie-disclaimer
  2. Activate logger
  3. Go to elisaviihde.fi

In the logger, you'll see that the generic filter is reported instead of the specific.

If you change the order:

elisaviihde.fi##.ea-cookie-disclaimer
##.ea-cookie-disclaimer

Logger will report the specific one as it should.

Expected behavior

The logger would always report the specific filter over the generic as it was the purpose of this commit:

gorhill/uBlock@c25938f

Actual behavior

The logger reports a generic cosmetic filter over a specific one, if the generic filter is listed before the specific in the list.

uBlock Origin version

1.42.5b1

Browser name and version

Firefox 99.0.1

Operating System and version

Windows 10

@peace2000
Copy link
Member Author

peace2000 commented Apr 17, 2022

Did some digging.

1.39.2 is the last stable version where this works correctly.
1.40.0 doesn't work correctly since this version. Maybe this commit is related to the issue? gorhill/uBlock@72bb894

@gwarser
Copy link

gwarser commented Apr 17, 2022

@peace2000 is this fixed in 1.42.4? I cannot reproduce in Nightly.

@peace2000
Copy link
Member Author

No, I can repro this issue in that version as well. 1.39.2 is the last stable version where this works correctly.

@gwarser

@gwarser
Copy link

gwarser commented Apr 17, 2022

Weird. It really must be related with sequence of data in storage, because no matter what I do, I cannot reproduce in dirty profile. I can in clean installation.

@gorhill
Copy link
Member

gorhill commented Apr 17, 2022

Hypothesis: Could be a regression from gorhill/uBlock@72bb894.

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 25, 2022
@peace2000
Copy link
Member Author

Tested the latest dev build, seems to be working.

@gorhill gorhill closed this as completed Apr 26, 2022
@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants