Classify Google Web Preview as a Spider #234
Merged
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commenthol
reviewed
Apr 20, 2017
regexes.yaml
Outdated
| @@ -4864,6 +4864,15 @@ device_parsers: | |||
| model_replacement: 'Desktop' | |||
|
|
|||
| ########## | |||
| # Google Web Preview Spider | |||
| ########## | |||
| - regex: 'Google Web Preview' | |||
There was a problem hiding this comment.
Can you please add this rule to the "Spider regex" in line 4860? This should still be a faster processing than adding a new rule. E.g. WhatsApp|masscan|Google Web Preview)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classify
Google Web Previewas a Spider.We regularly see web preview user agent strings of the form
Mozilla/5.0 (en-us) AppleWebKit/525.13 (KHTML, like Gecko; Google Web Preview) Version/3.1 Safari/525.13. The os and browser vary butGoogle Web Previewis always present.This change classifies them as a
Spiderbut still populates the OS and browser attributes if possible.