Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when clicking permissions button on address bar on some sites #1438

Closed
4 tasks done
Metrokoto opened this issue Sep 4, 2024 · 12 comments
Closed
4 tasks done
Labels
bug Something isn't working

Comments

@Metrokoto
Copy link

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

No

Are you sure?

No

Cromite version

Version 128.0.6613.116 (Official Build) (64-bit)

Device architecture

windows

Platform version

Windows 10

Android Device model

Not android

Is the device rooted?

No

Changed flags

none

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

Crashes when trying to generate a report and clicking save does nothing, can't do this

Describe the bug

Clicking the permissions icon on the address bar causes a crash to occur and on some sites it doesn't

Steps to reproduce the bug

Just go on different sites and try clicking on the permissions icon, sometimes they will crash and sometimes they won't, I can't try it now as I will lose the bug report progress yet again, but just trust me when I say that sites I frequent often don't seem to do it but new ones do, no clue why.

Expected behavior

Permissions menu opens up

Screenshots

No response

@Metrokoto
Copy link
Author

Metrokoto commented Sep 4, 2024

Clicking the permissions icon on the address bar causes a crash to occur and on some sites it doesn't

Example: For me github.com doesn't have the issue but nytimes.com does

@Metrokoto
Copy link
Author

Metrokoto commented Sep 4, 2024

This was an issue I noticed back in 127 and then forgot about it, I stayed on version 126 for a long time hoping it was fixed but here we go again.

@Metrokoto
Copy link
Author

On sites that don't crash instantly when I press the permissions icon, if I click reset permissions, it does crash.

@Metrokoto
Copy link
Author

@uazo Any chance of a rapid fix? This is making Cromite almost unusable.

@uazo
Copy link
Owner

uazo commented Sep 6, 2024

I do not detect any problem. is it possible to receive the crash log (\User Data\Crashpad\reports)?

@uazo uazo added the need triage I will look into it, I promise! label Sep 6, 2024
@Metrokoto
Copy link
Author

I do not detect any problem. is it possible to receive the crash log (\User Data\Crashpad\reports)?

Well it is crashing for me so there clearly is a problem... and no, the folder is empty.

@Metrokoto
Copy link
Author

Metrokoto commented Sep 6, 2024

@uazo

Ignore my last message, I managed to get it to spit one out by using the Crashpad launch args to output it to a custom directory path.

[link removed]

@jookk
Copy link

jookk commented Sep 7, 2024

On android (Cromite 128.0.6613.120) , it's impossible to change site permissions too. They are empty
Screenshot_20240907_070316

@uazo
Copy link
Owner

uazo commented Sep 8, 2024

call stack:

chrome.dll!logging::LogMessage::BuildCrashString(void)
chrome.dll!logging::LogMessage::Flush(void)
chrome.dll!logging::LogMessage::~LogMessage(void)
chrome.dll!??_GNotReachedLogMessage@?A0xAE67E2E6@logging@@[email protected]�()
chrome.dll!logging::CheckError::~CheckError(void)
chrome.dll!PageInfoUI::PermissionStateToUIString(class PageInfoUiDelegate *,struct PageInfo::PermissionInfo const &)
chrome.dll!PageInfoUI::PermissionMainPageStateToUIString(class PageInfoUiDelegate *,struct PageInfo::PermissionInfo const &)
chrome.dll!PermissionToggleRowView::UpdateUiOnPermissionChanged(void)
chrome.dll!PermissionToggleRowView::PermissionToggleRowView(class ChromePageInfoUiDelegate *,class PageInfoNavigationHandler *,struct PageInfo::PermissionInfo const &,bool)
chrome.dll!PageInfoMainView::SetPermissionInfo(class std::__Cr::vector<struct PageInfo::PermissionInfo,class std::__Cr::allocator<struct PageInfo::PermissionInfo> > const &,class std::__Cr::vector<class std::__Cr::unique_ptr<struct PageInfoUI::ChosenObjectInfo,struct std::__Cr::default_delete<struct PageInfoUI::ChosenObjectInfo> >,class std::__Cr::allocator<class std::__Cr::unique_ptr<struct PageInfoUI::ChosenObjectInfo,struct std::__Cr::default_delete<struct PageInfoUI::ChosenObjectInfo> > > >)
chrome.dll!PageInfo::PresentSitePermissions(void)
chrome.dll!PageInfo::InitializeUiState(class PageInfoUI *,class base::OnceCallback<void >)
chrome.dll!PageInfoMainView::PageInfoMainView(class PageInfo *,class ChromePageInfoUiDelegate *,class PageInfoNavigationHandler *,class PageInfoHistoryController *,class base::OnceCallback<void >)
chrome.dll!PageInfoViewFactory::CreateMainPageView(class base::OnceCallback<void >)
chrome.dll!InternalPageInfoBubbleView::GetClassMetaData(void)
chrome.dll!PageInfoBubbleView::CreatePageInfoBubble(class views::View *,class gfx::Rect const &,class aura::Window *,class content::WebContents *,class GURL const &,class base::OnceCallback<void >,class base::OnceCallback<void >)
chrome.dll!LocationBarView::ShowPageInfoDialog(void)
chrome.dll!views::ButtonController::OnMouseReleased(class ui::MouseEvent const &)

@uazo uazo added bug Something isn't working and removed need triage I will look into it, I promise! labels Sep 8, 2024
@Cbhack13
Copy link

@jookk, in case you are still having trouble...

On android (Cromite 128.0.6613.120) , it's impossible to change site permissions too. They are empty !

FWIW, I started having the same problem on Android a few days ago, and clearing the app cache seems to have fixed it for me.

@Metrokoto
Copy link
Author

@uazo Any update on this? The issue still persists, and is making Cromite rather inconvenient to use from time to time when I need to allow permissions on sites or view the SSL certificate.

@Metrokoto
Copy link
Author

Metrokoto commented Oct 18, 2024

Maybe this is related to the same issue causing #1543? Stack traces look similar.

uazo added a commit that referenced this issue Oct 20, 2024
…1571)

fix getting text for ask settings (#1543 #1438)
Modified desktop ui: permissions line text turns red when modified
@uazo uazo closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants