Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing while accessing opened tabs #213

Closed
5 tasks done
catgangdev opened this issue Aug 24, 2023 · 9 comments
Closed
5 tasks done

Crashing while accessing opened tabs #213

catgangdev opened this issue Aug 24, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@catgangdev
Copy link

catgangdev commented Aug 24, 2023

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

No

Cromite version

116.0.5845.111

Device architecture

arm64-v8a

Android version

13

Device model

Xiaomi Redmi note 10 Pro

Changed flags

No flags changed

Is this bug happening in an incognito tab?

No

Is this bug caused by the adblocker?

No

Is this bug a crash?

4b0ccb4a-9bad-457f-ba6b-670bc5112eaf.zip

Describe the bug

When tapping to open tabs app is crashing.

Steps to reproduce the bug

Go to homepage.
Press Tab menu.
App crash

Expected behavior

Tab menu should open.

Screenshots

None

@uazo
Copy link
Owner

uazo commented Aug 24, 2023

stack trace:

java.lang.NullPointerException: Attempt to read from field 'android.graphics.drawable.Drawable kr1.a' on a null object reference
	at Kp1.onResult(chromium-ChromePublic.apk-stable-584511104:180)
	at Ir1.onResult(chromium-ChromePublic.apk-stable-584511104:5)
	at io1.onResult(chromium-ChromePublic.apk-stable-584511104:23)
	at org.chromium.base.Callback$Helper.onObjectResultFromNative(chromium-ChromePublic.apk-stable-584511104:1)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:339)
	at android.os.Looper.loopOnce(Looper.java:179)
	at android.os.Looper.loop(Looper.java:344)
	at android.app.ActivityThread.main(ActivityThread.java:8248)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

@uazo uazo added bug Something isn't working need triage I will look into it, I promise! labels Aug 24, 2023
@uazo
Copy link
Owner

uazo commented Aug 24, 2023

deobfuscated:

java.lang.NullPointerException: Attempt to read from field 'android.graphics.drawable.Drawable org.chromium.chrome.browser.tasks.tab_management.TabListFaviconProvider$TabFavicon.mDefaultDrawable' on a null object reference
        at org.chromium.chrome.browser.tasks.tab_management.TabListFaviconProvider$TabFavicon.getDefaultDrawable(TabListFaviconProvider.java:63)
        at org.chromium.chrome.browser.tasks.tab_management.TabGridViewBinder.lambda$updateThumbnail$7(TabGridViewBinder.java:320)
        at org.chromium.chrome.browser.tasks.tab_management.TabListMediator$ThumbnailFetcher.lambda$fetch$0(TabListMediator.java:246)
        at org.chromium.chrome.browser.compositor.layouts.content.TabContentManager.lambda$refetchEtc1$8(TabContentManager.java:532)
        at org.chromium.base.Callback$Helper.onObjectResultFromNative(Callback.java:41)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:339)
        at android.os.Looper.loopOnce(Looper.java:179)
        at android.os.Looper.loop(Looper.java:344)
        at android.app.ActivityThread.main(ActivityThread.java:8248)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

@uazo
Copy link
Owner

uazo commented Aug 24, 2023

@catgangdev ops.. sorry, my fault, sometimes make absurd mistakes.
here I forgot to check the null condition.
I'll prepare a release for verification.

@catgangdev
Copy link
Author

@catgangdev ops.. sorry, my fault, sometimes make absurd mistakes. here I forgot to check the null condition. I'll prepare a release for verification.

No problem man. You are doing a great job.👍

@uazo
Copy link
Owner

uazo commented Aug 24, 2023

@Kirshi912
Copy link

I cant replace my current cromite with that so i uninstalled it first. I tested it for a while and seems fine.

@uazo
Copy link
Owner

uazo commented Aug 24, 2023

great, thanks!

@catgangdev
Copy link
Author

uazo added a commit that referenced this issue Aug 24, 2023
@uazo uazo removed the need triage I will look into it, I promise! label Aug 24, 2023
@catgangdev
Copy link
Author

Fixed in test build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants