Crash when #android-improved-bookmarks is enabled

[ItsVovix]

Preliminary checklist

• I have read the README.
• I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
• I have read the FAQs.
• I have updated Cromite to the latest version. The bug is reproducible on this latest version.
• This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

No

Cromite version

116.0.5845.180

Device architecture

arm64-v8a

Platform version

Android 13

Android Device model

Xiaomi MI 9

Is the device rooted?

Yes

Changed flags

#adaptive-button-in-top-toolbar-customization - enabled
#enable-parallel-downloading - enabled
#move-top-toolbar-to-bottom - enabled
#enable-search-ready-omnibox - enabled
#media-picker-adoption - enabled
#paint-preview-demo - disabled
#android-improved-bookmarks - enabled

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

8957ac52-32e4-4d9b-a726-0f5224c531d0.zip

Android crash report:

time: 1694346229714
msg: java.lang.NullPointerException: Attempt to invoke interface method 'android.view.MenuItem android.view.MenuItem.setVisible(boolean)' on a null object reference
stacktrace: java.lang.NullPointerException: Attempt to invoke interface method 'android.view.MenuItem android.view.MenuItem.setVisible(boolean)' on a null object reference
	at org.chromium.chrome.browser.bookmarks.BookmarkToolbar.R(chromium-ChromePublic.apk-stable-584518004:24)
	at org.chromium.chrome.browser.bookmarks.BookmarkToolbar.Y(chromium-ChromePublic.apk-stable-584518004:9)
	at Pl.f(chromium-ChromePublic.apk-stable-584518004:75)
	at YW0.b(chromium-ChromePublic.apk-stable-584518004:9)
	at cX0.c(chromium-ChromePublic.apk-stable-584518004:22)
	at org.chromium.ui.modelutil.PropertyModel.n(chromium-ChromePublic.apk-stable-584518004:35)
	at Tl.a(chromium-ChromePublic.apk-stable-584518004:33)
	at hl.h(chromium-ChromePublic.apk-stable-584518004:5)
	at Rl.onResult(chromium-ChromePublic.apk-stable-584518004:80)
	at Po.run(chromium-ChromePublic.apk-stable-584518004:5)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7933)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:941)

Describe the bug

When the flag #android-improved-bookmarks is enabled, the browser crashes whenever the bookmarks menu is opened.

Steps to reproduce the bug

1. Go to chrome://flags
2. Enable #android-improved-bookmarks flag
3. Relaunch browser
4. Tap on "Bookmarks" in the three dot menu or go to chrome://bookmarks (which makes the browser crash when opened until the said tab is closed)

Expected behavior

The browser should open the new experimental bookmark menu as can be seen in chrome.

Screenshots

No response

[uazo]

android-improved-bookmarks enabled

what does that flag do?

[ItsVovix]

it enables a new overhauled bookmark menu as can be seen in the screenshot below (i forgot to attach it last time, sorry)

Details

[uazo]

could solve #262 ?

[uazo]

stack trace:

java.lang.NullPointerException: Attempt to invoke interface method 'android.view.MenuItem android.view.MenuItem.setVisible(boolean)' on a null object reference
at org.chromium.chrome.browser.bookmarks.BookmarkToolbar.showNormalView(BookmarkToolbar.java:232)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbar.setBookmarkUiMode(BookmarkToolbar.java:90)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbarViewBinder.bind(BookmarkToolbarViewBinder.java:25)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbarCoordinator$$ExternalSyntheticLambda0.bind(Unknown Source:6)
at org.chromium.ui.modelutil.PropertyModelChangeProcessor.onPropertyChanged(PropertyModelChangeProcessor.java:89)
at org.chromium.ui.modelutil.PropertyModelChangeProcessor.$r8$lambda$24PR1_E-HzQeZ5B9-6klYXNTWZk(Unknown Source:0)
at org.chromium.ui.modelutil.PropertyModelChangeProcessor$$ExternalSyntheticLambda0.onPropertyChanged(Unknown Source:2)
at org.chromium.ui.modelutil.PropertyObservable.notifyPropertyChanged(PropertyObservable.java:68)
at org.chromium.ui.modelutil.PropertyModel.set(PropertyModel.java:421)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbarMediator.onUiModeChanged(BookmarkToolbarMediator.java:230)
at org.chromium.chrome.browser.bookmarks.BookmarkManagerMediator.notifyStateChange(BookmarkManagerMediator.java:615)
at org.chromium.chrome.browser.bookmarks.BookmarkManagerMediator.addUiObserver(BookmarkManagerMediator.java:670)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbarMediator.lambda$new$0$org-chromium-chrome-browser-bookmarks-BookmarkToolbarMediator(BookmarkToolbarMediator.java:88)
at org.chromium.chrome.browser.bookmarks.BookmarkToolbarMediator$$ExternalSyntheticLambda1.onResult(Unknown Source:4)
at org.chromium.base.Callback.lambda$bind$0(Callback.java:30)
at org.chromium.base.Callback$$ExternalSyntheticLambda0.run(Unknown Source:4)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7839)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

[Fmoment1]

Thank you Uazo!