FilenameAssocIterator needs __iter__ method, for py3.13.1 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, so a recent change did this (seems ok in 3.13.0, broken in 3.13.1)? Worrying. |
|
Yes. At the bottom of that discussion thread they even say they may revert, but I am glad to have fixed it. Are you happy with what I did? If so, I will just merge it, and leave it until we release. |
|
Yes, merge - good with me. |
|
Thanks Neil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python changes in 3.13.1 now requires strict adherence to the iter protocol, although it used to be looser. Apparently this was not intended, see here for some discussion. However, we should probably adhere to the strict definitions anyway.
I confess I don't fully understand the iterable protocol, but this change now passes all tests with python 3.13.1.