Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Companion for bt-web-v2 #61

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Initialize Companion for bt-web-v2 #61

merged 3 commits into from
Dec 16, 2024

Conversation

voctory
Copy link
Member

@voctory voctory commented Dec 16, 2024

Notes

Completes Workstream E: bt-web-v2 Companion Migration

  • Imported the Companion structure from bt-web-v1 and add BluePrint 2025 as the event
  • On the production environment, block non-admins from accessing non-Companion pages and redirect to Companion at /companion
  • Revert .env flag name change of REACT_APP_STAGE back to NEXT_PUBLIC_REACT_APP_STAGE
    • seems like we're doing client-side fetching which is why we need to expose the .env variable. Ideally, all fetchBackend requests should be running on Next.js server-side, might address this in another PR

Future Work

  • Before merging to main: we'll need to create the blueprint;2025 event on Production
  • Future refactoring: remove all 'fetch' calls and replace with fetchBackend
  • Remove dependency on /registrations API
  • Implement UI/UX from MMD Figma

Testing

Manual testing on local with npm run dev, localhost:3000/companion

image

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
biztech-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:21am

@voctory
Copy link
Member Author

voctory commented Dec 16, 2024

Adding Workstream C for review @liuisaac @AllanT102

@voctory voctory merged commit 8ae610b into dev Dec 16, 2024
2 checks passed
@voctory voctory deleted the init-companion branch December 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants