Companies Profiles and Map Page UI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
voctory
reviewed
Jan 11, 2025
Comment on lines
6
to
7
| import { TopNav } from "./navigation/top-nav"; | ||
| import { SideNav } from "./navigation/side-nav"; |
There was a problem hiding this comment.
small note that Izzy has refactored the Nav bars to go under a single component, so you may need to fix a merge conflict
| logo: "https://upload.wikimedia.org/wikipedia/commons/e/e8/Tesla_logo.png", | ||
| description: "3 delegates in attendance", | ||
| tags: ["AUTOMOTIVE", "R&D", "MECH ENGINEERING"], | ||
| profile_url: "/tesla" |
There was a problem hiding this comment.
I noticed CompanionItemRow already has the template string /companion/company/${company.profile_url}, so we would end up with a double slash here: /companion/company//tesla
AllanT102
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces the UI for the companies page. The following elements have been implemented:
Note:
Issue ticket number and link
Checklist before requesting a review
Images / Video of Feature
2025-01-09.20-57-35.1.mp4