Add DISTINCT to Jobs realm JobDataset query (#1332)

classes/DataWarehouse/Query/Jobs/JobDataset.php

@@ -146,4 +146,55 @@ public function getColumnDocumentation()
     {
         return $this->documentation;
     }
+
+    /**
+     * The query differs from the base class query because the same fact table
+     * row may correspond to multiple rows in the aggregate table (e.g. a job
+     * that runs over two days). Therefore the DISTINCT keyword is added to
+     * deduplicate.
+     *
+     * @see \DataWarehouse\Query\Query::getQueryString()
+     */
+    public function getQueryString($limit = null, $offset = null, $extraHavingClause = null)
+    {
+        $wheres = $this->getWhereConditions();
+        $groups = $this->getGroups();
+
+        $select_tables = $this->getSelectTables();
+        $select_fields = $this->getSelectFields();
+
+        if ( 0 == count($select_fields) ) {
+            $this->logAndThrowException("Cannot generate query string with no select fields");
+        }
+
+        $select_order_by = $this->getSelectOrderBy();
+
+        $format = <<<SQL
+SELECT DISTINCT
+  %s
+FROM
+  %s%s
+WHERE
+  %s
+%s%s%s%s
+SQL;
+
+        $data_query = sprintf(
+            $format,
+            implode(",\n  ", $select_fields),
+            implode(",\n  ", $select_tables),
+            ( "" == $this->getLeftJoinSql() ? "" : "\n" . $this->getLeftJoinSql() ),
+            implode("\n  AND ", $wheres),
+            ( count($groups) > 0 ? "GROUP BY " . implode(",\n  ", $groups) : "" ),
+            ( null !== $extraHavingClause ? "\nHAVING $extraHavingClause" : "" ),
+            ( count($select_order_by) > 0 ? "\nORDER BY " . implode(",\n  ", $select_order_by) : "" ),
+            ( null !== $limit && null !== $offset ? "\nLIMIT $limit OFFSET $offset" : "" )
+        );
+
+        $this->logger->debug(
+            sprintf("%s %s()\n%s", $this, __FUNCTION__, $data_query)
+        );
+
+        return $data_query;
+    }
 }