Modify xdmod source for php7 compatibility #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed up xdmod core source based on the output of php7cc version compatibility checker (https://github.com/sstalle/php7cc). This provided an opportunity to delete some woefully dated source code that used deprecated syntax and packages.
This is necessarily a mixed bag of changes, consisting of code deletions, class renaming, deletion of unused database tables, and adjustment of syntax in the test harness.
Refer to pull requests https://github.com/ubccr/xdmod-xsede/pull/29 and ubccr/xdmod-appkernels#18 for associated changes for php7 compatibility
As spelled out in the original commit remarks:
Motivation and Context
This PR helps prepare xdmod for a migration to a newer PHP version, and provides the opportunity to prune some unused and outdated code.
Tests performed
All existing integration and unit tests were run without incident. Where coverage is limited (e.g. user profile), manual testing was done to ensure no behavioral changes were introduced.
Types of changes
Checklist: