Cherry Pick important bugfixes from 8.6 #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request ubccr#967 added extra code to the report manager that manipulated the start and end times of charts in a report. This broke the report generator. These changes appear to not be necessary at all and must have been added by mistake.
The getRoleReport() decoding was manging the chart data. This is seen for charts that have either & or = in the config. For example: global_filters=%7B%22data%22%3A%5B%7B%22id%22%3A%22institution%3D400%22%2C%22value_id%22%3A%22400%22%2C%22dimension_id%22%3A%22institution%22%2C%22checked%22%3Atrue%7D%5D%2C%22total%22%3A1%7D
jtpalmer
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request cherry-picks the commits from three bug fixes that went into the XSEDE 8.6 release.
These are:
#1190
#1178
#1177