Improve data warehouse export logging #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
added
enhancement
jpwhite4
reviewed
Jan 24, 2020
| @@ -16,6 +16,15 @@ | |||
|
|
|||
| class BatchProcessor extends Loggable | |||
| { | |||
| // Constants used in log messages. | |||
| const LOG_MODULE_KEY = 'module'; | |||
There was a problem hiding this comment.
lolzers the name of the constant is longer that the value!
There was a problem hiding this comment.
Also, "module" is probably a poor choice since we're using that to mean something else. Let me know if you have any other suggestions. I'm trying to group these messages since they include some that could be run by both the web server and the batch process.
|
Kudos, SonarCloud Quality Gate passed!
|
jpwhite4
approved these changes
Jan 24, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional logging and improves existing logging to add more details.
Motivation and Context
The logged information is necessary to provide details on the use of the data warehouse export features.
https://app.asana.com/0/15230011293693/1146676887787307
Tests performed
No tests
Types of changes
Checklist: