Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close report generator "Save As" dialog after saving #1279

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Close report generator "Save As" dialog after saving #1279

merged 1 commit into from
Apr 6, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Apr 3, 2020

Description

After saving a report using the "Save As" feature close the "Save As" window.

Motivation and Context

https://app.asana.com/0/15230011293693/62691924780816

Tests performed

Updated UI test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added enhancement Enhancement of the functionality of an existing feature Category:Report Generator Report Generator labels Apr 3, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Apr 3, 2020
@jtpalmer jtpalmer requested review from plessbd and jpwhite4 April 3, 2020 17:16
@jtpalmer jtpalmer merged commit f3df333 into ubccr:xdmod9.0 Apr 6, 2020
@jtpalmer jtpalmer deleted the report-generator-save-as-close branch April 6, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

Assignees
No one assigned
Labels
Category:Report Generator Report Generator enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd