Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute acl-config path in xdmod-ingestor #1306

Merged
merged 3 commits into from
May 15, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented May 8, 2020

Description

Changes the acl-config invocation from xdmod-ingestor to use an absolute path.

Motivation and Context

It is possible that other executables name acl-config may exist in the PATH of the user running xdmod-ingestor. (This just happened to me.)

This may result in the wrong acl-config being executed. This change prevents that and ensures that the correct file is executed.

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added enhancement Enhancement of the functionality of an existing feature Category:General General labels May 8, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone May 8, 2020
@jtpalmer jtpalmer requested a review from jpwhite4 May 8, 2020 16:38
@jtpalmer jtpalmer merged commit 0f4b721 into ubccr:xdmod9.0 May 15, 2020
@jtpalmer jtpalmer deleted the acl-config-path branch May 15, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants