Prevent LSF commands encoding warnings #1377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents possibly non-UTF-8 encoded data from being passed to
json_encode
. Specifically, the commands contained in LSF accounting logs aren't guaranteed to be utf8.Motivation and Context
This prevent PHP warnings. I think it's a very low risk change.
https://help.xdmod.org/a/tickets/11449
Tests performed
Added new unit test.
Types of changes
Checklist: