Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent LSF commands encoding warnings #1377

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Prevents possibly non-UTF-8 encoded data from being passed to json_encode. Specifically, the commands contained in LSF accounting logs aren't guaranteed to be utf8.

Motivation and Context

This prevent PHP warnings. I think it's a very low risk change.

https://help.xdmod.org/a/tickets/11449

Tests performed

Added new unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:ETL Extract Transform Load labels Jul 16, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jul 16, 2020
@jtpalmer jtpalmer merged commit 4bebd69 into ubccr:xdmod9.0 Jul 17, 2020
@jtpalmer jtpalmer deleted the lsf-command-encoding branch July 17, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:ETL Extract Transform Load
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants