Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix institution loading during manual user creation #1446

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Updates the TGUserDropDown (used for the "Map To" field when creating users in the internal dashboard) to execute the cascade options after the field is set programmatically. (Previously the cascade options were only executed after the select event which is only triggered by a user selecting an item from the drop down.)

Motivation and Context

Using the "Find" option during user creation wasn't setting the institution which then produces an error message when attempting to create the user.

https://app.asana.com/0/807770147051221/1193376020829900/f

Tests performed

Tested manually.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@jtpalmer jtpalmer added bug Bugfixes Category:Internal Dashboard Internal Dashboard labels Sep 11, 2020
@jtpalmer jtpalmer added this to the 9.5.0 milestone Sep 11, 2020
@jtpalmer jtpalmer requested a review from ryanrath September 11, 2020 17:11
ryanrath
ryanrath previously approved these changes Sep 11, 2020
Copy link
Contributor

@ryanrath ryanrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as soon as Shippable finishes passing.

Copy link
Contributor

@ryanrath ryanrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus function argument names.

html/gui/js/TGUserDropDown.js Outdated Show resolved Hide resolved
@jtpalmer jtpalmer merged commit 104b8a9 into ubccr:xdmod9.5 Sep 16, 2020
@jtpalmer jtpalmer deleted the create-user-dd-cascade branch September 16, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:Internal Dashboard Internal Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants