Fix hang in nodejs etl on mysql connection failure. #1477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By code inspection there is a possible hang condition if
the mysql connection fails in the ETL logging part of the
code.
Tests performed
I tested this code change manually by editing the etl_profile and
temporarily editing the mysql configuration so that the connection
would fail:
mysqlConfig.host = 'qweqw';
The output of the process was then:
and then the process exited. Without the bug fix the output looks like this:
and the process hangs forever.