Improve aggregation bind params #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgallo
added
the
enhancement
plessbd
suggested changes
Feb 2, 2017
| // information will need to come from the last and first slice, | ||
| // respecitively (see note below). | ||
|
|
||
| $availableParamKeys = array_map( |
There was a problem hiding this comment.
This is done in two places, please make it a function.
| // Make all of the data for each aggregation period available to the | ||
| // query. Change the array keys into bind parameters. | ||
|
|
||
| $availableParamKeys = array_map( |
There was a problem hiding this comment.
This is done in two places, please make it a function.
plessbd
approved these changes
Feb 2, 2017
plessbd
pushed a commit
to plessbd/xdmod
that referenced
this pull request
Feb 3, 2017
* Make all aggregation period data available as bind parameters to query * Fix phpcs issues * Addressed code review comments (make redundant code into a function)
ryanrath
pushed a commit
to ryanrath/xdmod
that referenced
this pull request
Apr 27, 2017
* Make all aggregation period data available as bind parameters to query * Fix phpcs issues * Addressed code review comments (make redundant code into a function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not all information returned for an aggregation period was available as a bind parameter for aggregators. Now, any columns returned by
getDirtyAggregationPeriods()will automatically be made available as a bind parameter for use in aggregation queries.Motivation and Context
Laying the groundwork for using
start_dateandend_datein the new Accounts realm rather thanstart_date_tsandend_date_ts, which are not available.Tests performed
Ran ingestion and aggregation of the past 100 days worth of jobs including experimental batch aggregation.
Types of changes
Checklist: