Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing timing issues in Metric Explorer UI Tests #953

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Fixing timing issues in Metric Explorer UI Tests #953

merged 1 commit into from
Jun 7, 2019

Conversation

tpetrus
Copy link
Contributor

@tpetrus tpetrus commented Jun 7, 2019

Fixed the way that chart title is tested in ME

Description

I changed the way that the current test checks to make sure the HighCharts graph displays correctly. The issue was that the test was trying to set the title of the chart too quickly, so I modified the test to wait and change the title when it was possible.

Also modified setDateRange to properly wait until the mask disappears before setting the date.

Motivation and Context

It fixed a failed test when UI tests were run

Tests performed

Created instance of XDMoD in docker container and ran the UI Tests.

Docker container using tas-tools-ext-01.ccr.xdmod.org/centos7_6-open8.1.2:latest image. ran "~/bin/services start", then ran UI tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@plessbd plessbd added Category:General General qa / testing Updates/additions to tests labels Jun 7, 2019
@plessbd plessbd changed the title Fixing timing issues in ME UI Tests Fixing timing issues in Metric Explorer UI Tests Jun 7, 2019
@plessbd plessbd merged commit 5483ad2 into ubccr:xdmod8.5 Jun 7, 2019
@plessbd plessbd added this to the 8.5.0 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants