Update Average Wall Hours statistic to be exact rather than approximate in aggregate mode #964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the average wall hours statistic to be exact rather than approximate. Also update the help description to accurately describe the algorithm.
The keen observer may wonder why the regression test results are unchanged. The reason is that the old code produced the correct answer when all of the jobs that contributed to the calculation ended in the specified time range. This is the case for the regression tests.
Manually double checking the calculation is done by running a query on the fact tables and comparing with the XDMoD output. Care must be taken because the wallduration is not the total wall time of the job. it is the contribution of the job wall time in the time period. The following sql can be used to validate the results of group by pi from 2016-12-01 to 2016-12-30 (The -31 in the sql is not a typo: recall an end time of 2016-12-30 includes 2016-12-30):