Add chart link button to metric explorer #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
Jul 12, 2019
mkzia
force-pushed
the
addChartLinkButton
branch
from
9d4ca9b to
7a4fffd
Compare
mkzia
force-pushed
the
addChartLinkButton
branch
from
8df311d to
03f4914
Compare
jpwhite4
reviewed
Jul 12, 2019
jpwhite4
approved these changes
Jul 15, 2019
plessbd
added
Category:Metric Explorer
jpwhite4
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add button in the metrics explorer to show a link to the current chart.
Motivation and Context
I need a way to forward from OOD to XDMoD. This PR adds support for adding chart config in the GET parameter that metric explorer can parse and display.
Tests performed
Manually tested the functionality.
Types of changes
Checklist: