Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code reuse in sections that use modals #117

Closed
bobheadxi opened this issue Apr 26, 2020 · 0 comments · Fixed by #131
Closed

improve code reuse in sections that use modals #117

bobheadxi opened this issue Apr 26, 2020 · 0 comments · Fixed by #131
Assignees
Labels
internal Internal, non-user-facing work such as refactors

Comments

@bobheadxi
Copy link
Member

Teams and Projects both use TeamProjectModal, and the boilerplate to activate the modal has a lot of repetition and is more or less copy-pasted between the two sections. Adding new features like #94 involves duplicating code to both sections as well because of this.

There's probably some Vue best practices we can leverage to reduce this issue

@bobheadxi bobheadxi added the internal Internal, non-user-facing work such as refactors label Apr 26, 2020
@bobheadxi bobheadxi self-assigned this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal, non-user-facing work such as refactors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant