Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move modal state controls to a shared mixin #131

Merged
merged 4 commits into from
Apr 28, 2020
Merged

move modal state controls to a shared mixin #131

merged 4 commits into from
Apr 28, 2020

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Apr 27, 2020 •
edited
Loading

closes #117

moves modal state controller to a Mixin to remove duplicated modal control logic

@bobheadxi bobheadxi merged commit 4ecec75 into master Apr 28, 2020
@bobheadxi bobheadxi deleted the modal-mixin branch April 28, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachitMalik12 RachitMalik12 Awaiting requested review from RachitMalik12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve code reuse in sections that use modals
1 participant
@bobheadxi