Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate all atomics automatically #77

Merged
merged 5 commits into from
May 15, 2020
Merged

Generate all atomics automatically #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9866630
Generalize gen-valuewrapper into atomicwrapper
abhinav May 14, 2020
af220de
Separate files for each atomic type
abhinav May 14, 2020
f455d48
bool: Generate with gen-valuewrapper
abhinav May 14, 2020
e63519f
float64: Generate with gen-atomicwrapper
abhinav May 14, 2020
b3957f7
duration: Generate with gen-atomicwrapper
abhinav May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ export GOBIN ?= $(shell pwd)/bin

GOLINT = $(GOBIN)/golint
GEN_ATOMICINT = $(GOBIN)/gen-atomicint
GEN_VALUEWRAPPER = $(GOBIN)/gen-valuewrapper
GEN_ATOMICWRAPPER = $(GOBIN)/gen-atomicwrapper

GO_FILES ?= $(shell find . '(' -path .git -o -path vendor ')' -prune -o -name '*.go' -print)

# Also update ignore section in .codecov.yml.
COVER_IGNORE_PKGS = \
go.uber.org/atomic/internal/gen-atomicint \
go.uber.org/atomic/internal/gen-valuewrapper
go.uber.org/atomic/internal/gen-atomicwrapper

.PHONY: build
build:
Expand All @@ -29,8 +29,8 @@ gofmt:
$(GOLINT):
go install golang.org/x/lint/golint

$(GEN_VALUEWRAPPER): $(wildcard ./internal/gen-valuewrapper/*)
go build -o $@ ./internal/gen-valuewrapper
$(GEN_ATOMICWRAPPER): $(wildcard ./internal/gen-atomicwrapper/*)
go build -o $@ ./internal/gen-atomicwrapper

$(GEN_ATOMICINT): $(wildcard ./internal/gen-atomicint/*)
go build -o $@ ./internal/gen-atomicint
Expand All @@ -54,7 +54,7 @@ cover:
go tool cover -html=cover.out -o cover.html

.PHONY: generate
generate: $(GEN_ATOMICINT) $(GEN_VALUEWRAPPER)
generate: $(GEN_ATOMICINT) $(GEN_ATOMICWRAPPER)
go generate ./...

.PHONY: generatenodirty
Expand Down
238 changes: 0 additions & 238 deletions atomic.go
View file
Open in desktop

This file was deleted.

Loading