Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Don't use '.' imports #59

Merged
merged 1 commit into from
Oct 28, 2023
Merged

lint: Don't use '.' imports #59

merged 1 commit into from
Oct 28, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Oct 28, 2023

Recent versions of golangci-lint and revive
complain about use of '.' imports.

emitter_stack_test.go:10:2: dot-imports: should not use dot imports (revive)
scheduler_test.go:8:2: dot-imports: should not use dot imports (revive)

Replace these uses with regular imports.

Recent versions of golangci-lint and revive
complain about use of '.' imports.

```
emitter_stack_test.go:10:2: dot-imports: should not use dot imports (revive)
scheduler_test.go:8:2: dot-imports: should not use dot imports (revive)
```

Replace these uses with regular imports.
@abhinav abhinav enabled auto-merge (squash) October 28, 2023 20:17
@abhinav abhinav requested a review from r-hang October 28, 2023 20:17
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #59 (b629a47) into main (6357be2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files          32       32           
  Lines        2603     2603           
=======================================
  Hits         2270     2270           
  Misses        269      269           
  Partials       64       64           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit 60f5c0f into uber-go:main Oct 28, 2023
@abhinav abhinav deleted the lintfix branch October 28, 2023 21:54
sywhang added a commit that referenced this pull request Oct 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Replace uses of go.uber.org/atomic
with the standard library's sync/atomic.

On top of that, upgrade to the latest release of multierr
to pull in uber-go/multierr#72 which made a similar change there.

With these two changes combined,
drop the dependency on go.uber.org/atomic completely.

(Won't pass lint until #59 merges.)

Co-authored-by: Sung Yoon Whang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants