Dependency Upgrade + Preparations for 1.0 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaishavGandhi
commented
Mar 7, 2020
| - '0.X API': | ||
| - 'rxdogtag': 0.x/rxdogtag/com.uber.rxdogtag/ | ||
| - 'rxdogtag-autodispose': 0.x/rxdogtag-autodispose/com.uber.rxdogtag.autodispose/ | ||
| - '1.X API': |
There was a problem hiding this comment.
Not sure if it's worth keeping 0.x API reference considering that nothing has changed. Thoughts?
Seems like jetpack benchmark fails on Java 9
ShaishavGandhi
commented
Mar 7, 2020
.github/workflows/ci.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| # TODO Add 13 once Gradle 6.0 is out | |||
| java_version: [1.8, 9, 10, 11, 12] | |||
| java_version: [1.8] | |||
There was a problem hiding this comment.
Seems like jetpack benchmark barfs on Java 9 and above
https://github.com/uber/RxDogTag/pull/55/checks?check_run_id=492399969
There was a problem hiding this comment.
Update. Only 9 fails for JavaDateTimeException (while compiling)
This reverts commit 44d1898.
ZacSweers
approved these changes
Mar 7, 2020
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.6-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.2.2-bin.zip | |||
There was a problem hiding this comment.
Hmm it auto changes to bin after i run ./gradlew wrapper. Do you know if that's the correct command to run?
| - '0.X API': | ||
| - 'rxdogtag': 0.x/rxdogtag/com.uber.rxdogtag/ | ||
| - 'rxdogtag-autodispose': 0.x/rxdogtag-autodispose/com.uber.rxdogtag.autodispose/ | ||
| - '1.X API': |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #53