Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pip install xgboost if already installed #134

Closed
wants to merge 1 commit into from

Conversation

fritzo
Copy link
Contributor

@fritzo fritzo commented Feb 12, 2020

Addresses #100

This adds a workaround to setup.py to avoid pip installing xgboost if it can already be imported. This works for me when creating a new conda env, e.g.

conda create -n my_env python=3.6
conda activate my_env
conda install -c conda-forge xgboost
cd causalml
pip install -e .  # works after this PR

I am unsure whether this messes up the requirements pypi requirements, i.e. when releasing. This may only work when installing locally via pip install ..

@fritzo fritzo requested a review from jeongyoonlee February 12, 2020 23:53
@fritzo
Copy link
Contributor Author

fritzo commented Feb 13, 2020

Closing because I believe this messes up requirements when pip uploading. I'll reopen if we can find a solution. cc @neerajprad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant