-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: cleanup and pin cibuildwheel #188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 213 213
=========================================
Hits 213 213 Continue to review full report at Codecov.
|
So this refactoring doesn't seem to work (yet). |
I thought pipx recognized a version number without having to use --spec. The action doesn't have to worry about that. |
Awesome! Thanks @henryiii! Would you happen to know if it's similarly easy to extend this to also build for |
But I should also figure out how this overlaps with #183 |
It should be pretty easy, depends on if you support Aarch64 (#183) and if there are any dependencies that don't support Apple Silicon yet. I could draft an example PR, possibly. |
Cleaning up the file just a bit, mostly pinning cibuildwheel, as version 2.0 will drop Python 2/3.5, which might be a surprise if you just always install the latest version. It looks like you might use dependabot + pinning in actions, so you might like the action form of cibuildwheel better,
but it's about to movefrom joerick/cibuildwheel to pypa/cibuildwheel, so that could be done after the move to pick up the shiny new name. :) Edit: moved, so using action.