Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cibuildwheel config to build Apple silicon wheels #221

Merged
merged 12 commits into from
Apr 11, 2022

Conversation

kylebarron
Copy link
Contributor

@kylebarron kylebarron commented Apr 8, 2022

Apple Silicon wheels seem to build out of the box with cibuildwheel v2. (likely relying on the fixed issues linked in #190).

The diff of new wheels added with this PR is the following:

4a5
> h3-3.7.3-cp310-cp310-macosx_11_0_arm64.whl
15a17
> h3-3.7.3-cp38-cp38-macosx_11_0_arm64.whl
19a22
> h3-3.7.3-cp39-cp39-macosx_11_0_arm64.whl

Closes #190, closes #204, closes #219.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #221 (a3eb23e) into master (ef3f8f4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          425       425           
=========================================
  Hits           425       425           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3f8f4...a3eb23e. Read the comment docs.

@ajfriend
Copy link
Contributor

Is this more or less ready to land?

@kylebarron kylebarron marked this pull request as ready for review April 11, 2022 04:56
@kylebarron
Copy link
Contributor Author

Yeah I updated this branch with master and it should be good to go when green

@kylebarron
Copy link
Contributor Author

Note that this makes Mac wheels the slowest job at 20 minutes or so. If that's too long we could always split Mac Intel and Mac Apple Silicon into two separate jobs.

@dfellis
Copy link
Collaborator

dfellis commented Apr 11, 2022

Note that this makes Mac wheels the slowest job at 20 minutes or so. If that's too long we could always split Mac Intel and Mac Apple Silicon into two separate jobs.

I personally don't think the extra complexity is worth the time to make that change, but up to you guys. :)

@ajfriend
Copy link
Contributor

Note that this makes Mac wheels the slowest job at 20 minutes or so. If that's too long we could always split Mac Intel and Mac Apple Silicon into two separate jobs.

I personally don't think the extra complexity is worth the time to make that change, but up to you guys. :)

Let's see how annoying it gets :)

@ajfriend ajfriend merged commit 034a41e into uber:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants