[PiranhaJava] Delete statements using EasyMock and JUnit API #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2021 18:25
Fixed the Swift CI issue Addressed the issues mentioned in the PR and offline Added support for then* pattern Added delete statement logic for specific patterns menntioned in issue uber#104
added 3 commits
December 2, 2021 13:24
ketkarameya
commented
Dec 10, 2021
| @@ -369,9 +363,9 @@ private API getXPAPI( | |||
| for (PiranhaMethodRecord methodRecord : methodRecordsForName) { | |||
| // when argumentIndex is specified, if mit's argument at argIndex doesn't match xpFlagName, | |||
| // skip to next method property map | |||
| Optional<Integer> optionalArgumentIdx = methodRecord.getArgumentIdx(); | |||
| OptionalInt optionalArgumentIdx = methodRecord.getArgumentIdx(); | |||
There was a problem hiding this comment.
My type change tool suggested this :)
ketkarameya
commented
Dec 10, 2021
| import javax.annotation.Nullable; | ||
|
|
||
| /** A class representing a method configuration record from properties.json */ | ||
| public class MethodRecord { |
There was a problem hiding this comment.
I extracted the super class MethodRecord from PiranhaMethodRecord
mkr-plse
reviewed
Dec 27, 2021
java/piranha/config/properties.json
Outdated
| { | ||
| "methodName": "when", | ||
| "argumentIndex": 0, | ||
| "recieverType":"org.mockito.Mockito", |
| .getUnnecessaryTestMethodRecords() | ||
| .stream() | ||
| .map( | ||
| mthd -> |
| @Nullable | ||
| static Boolean getValueBooleanFromMap(Map<String, Object> map, String key) { | ||
| Object value = map.get(key); | ||
| if (value instanceof String && !value.equals("")) { |
| @@ -541,6 +545,27 @@ public void testRemoveSpecificAPIpatterns() throws IOException { | |||
| " when(experimentation.isToggleEnabled(\"OTHER_FLAG\")).then(ans);", | |||
| " when(foobar()).thenReturn(false);", | |||
| " when(foobar()).thenAnswer(ans);", | |||
| "// Easymock Test scenarios", | |||
There was a problem hiding this comment.
Can we split these into multiple tests (easymock, ...)?
mkr-plse
approved these changes
Jan 3, 2022
java/README.md
Outdated
| Another top-level optional field is `unnecessaryTestMethodProperties`. Within that, there is an array of JSON objects, | ||
| having the fields `methodName`, `argumentIndex`, `receiverType`, `returnType` and `isStatic`. | ||
|
|
||
| In practice, often the refactored code produced by `piranha` results in unnecessary method invocations. For instance, |
There was a problem hiding this comment.
let us get rid of the term often :). How about "The refactored code may contain unnecessary method invocations".
| "", | ||
| "", | ||
| "", | ||
| " boolean b1 = someWrapper(when(true).thenCallRealMethod());", |
There was a problem hiding this comment.
I don't know, TBH. I just added it as a corner case to the test suite, assuming that if such a scenario appears it should not be refactored because the method someWrapper could be producing some required side effect.
There was a problem hiding this comment.
no worries. this is fine. we can iterate on this subsequently.
mkr-plse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new matchers for the EasyMock and Junit API