Solve for https://github.com/uber/piranha/issues/28 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkruber @lazaroclapp - This PR is a dedup of this old PR #30 Since there were challenges with CLA in the old PR, I opened this one. |
mkr-plse
suggested changes
Apr 20, 2020
mkr-plse
approved these changes
Apr 20, 2020
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves for flag name to be in these conditions:
Ability to use string-literal
getldvalue("dummy-flag")Ability to use constants
private static final String STALE_FLAG_NAME = "dummy-flag"; getldvalue(STALE_FLAG_NAME)