-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for vector-valued ZhangLi u #48
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 14 14
=========================================
Hits 14 14 ☔ View full report in Codecov by Sentry. |
@samjrholt Can you please review the new test |
I re-wrote all tests for Zhang Li, the diff is not really meaningful. The new tests all check some sort of DW motion. Testing the new methods with mumax3c remains to be done. |
to hopefully more meaningful names
Support in mumax3c is implemented in ubermag/mumax3c#88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Should we also have a test with a vector field? I think that is the only case which isn't covered at the moment.
Co-authored-by: Sam Holt <[email protected]>
@lang-m did you implement this or decide it wasn't needed? |
There was a test already: |
This is related to ubermag/micromagneticmodel#75 and ubermag/oommfc#133
Merging this test will also require some changes in mumax3c: either we can support the same functionality or disable the test. I will try that when I am on a suitable machine.